This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] MIPS gas: Fix broken relocation sorting

From: David Daney <ddaney at avtrex dot com>
To: Thiemo Seufer <ths at networkno dot de>
Cc: binutils at sourceware dot org, Richard Sandiford <richard at codesourcery dot com>, amodra at bigpond dot net dot au
Date: Mon, 11 Dec 2006 08:37:33 -0800
Subject: Re: [PATCH] MIPS gas: Fix broken relocation sorting
References: <4550F1D3.70705@avtrex.com> <87fycv2bk8.fsf@talisman.home> <45510560.6070907@avtrex.com> <20061107234256.GI19541@networkno.de>

Thiemo Seufer wrote:

David Daney wrote:
Richard Sandiford wrote:
Thus if we were indeed converting R_MIPS_GOT16 relocations against
local symbols into R_MIPS_GOT16 relocations against global symbols,
(1) would be the right fix.  But like I say, the bug appears at
first glance to be in pic_need_relax.
New version of the patch:

Tested as before with mipsel-linux cross build no regressions.

OK to commit?

If this looks better, I will restart my gcc-4.2 boot strap with this instead.
gas:
2006-11-06  David Daney  <ddaney@avtrex.com>
* config/tc-mips.c (pic_need_relax): Return true for section symbols.
gas/testsuite:
2006-11-06  David Daney  <ddaney@avtrex.com>
* gas/mips/elf-rel26.s: New test. * gas/mips/elf-rel26.d: Ditto. * gas/mips/mips.exp: Run it.
Ok.

Thiemo

Can I put this in the 2.17 branch as well? I have successfully bootstrapped and tested GCC 4.2 and 4.3 several times with binutils 2.17 + this patch with good results.

Also a related question: Is there going to be another official release from the 2.17 branch?

David Daney

Follow-Ups:
- Re: [PATCH] MIPS gas: Fix broken relocation sorting
  - From: Daniel Jacobowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]