This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix Score bugs, please review it.

From: Nick Clifton <nickc at redhat dot com>
To: ligang at sunnorth dot com dot cn
Cc: binutils at sourceware dot org, bjgnu at sunnorth dot com dot cn
Date: Tue, 31 Oct 2006 09:55:33 +0000
Subject: Re: [PATCH] Fix Score bugs, please review it.
References: <OF5BB5A9A9.F6E478CF-ON48257213.00172A5A-48257213.0037F467@sunnorth.com.cn>

Hi Ligang,

1. Emit error message if const operand is invalid.

gas/config/ * tc-score.c (data_op2): Check invalid operands. (my_get_expression): Const operand of some instructions can not be symbol in assembly. (get_insn_class_from_type): Handle instruction type Insn_internal. (do_macro_ldst_label): Modify inst.type. (Insn_PIC): Delete. include/opcode/ * score-inst.h (enum score_insn_type): Add Insn_internal. 2. Fix error message of simm15 outof range.
   gas/config/
   * tc-score.c (data_op2): The immediate value in lw is 15 bit signed.
3. Correct PCE instruction disassembly.
   opcodes/
   * score-dis.c (print_insn): Correct the error code to print correct
   PCE instruction disassembly.

Approved and applied. (Sorry about the delay).

Cheers
  Nick

References:
- [PATCH] Fix Score bugs, please review it.
  - From: ligang

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]