This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
re: Re: [patch] add target Score to Binutils
- From: ligang at sunnorth dot com dot cn
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 19 Sep 2006 18:37:17 +0800
- Subject: re: Re: [patch] add target Score to Binutils
- Sensitivity:
Nick Clifton <nickc@redhat.com> wrote on 2006-09-17 07:59:05:
> Hi Ligang,
>
> > I had done the whole process of copyright assignment with the FSF.
> > Attachment is the ASSIGNMENT.
>
> Thank you. It appears that I am not being informed of recent copyright
> assignments, so I was unaware of this. I will endevour to make sure
> that I am informed in the future.
>
> In the meantime I have checked in your submission. I did have quite a
> few problems with it, and normally I would have asked you to resubmit
> it, but I felt quite guilty at how long it had taken me to getting round
> to reviewing the patch. For future reference however please bear these
> points in mind:
>
> * Please provide the code as context diffs against the current
> sources in the mainline of the CVS repository. Hinting at where the
> changes ought to made in the generic files is not good enough, and
> providing code that does not compile because it uses functions that no
> longer exist is a very bad idea.
>
> * Please include ChangeLog entries with your patches. These should
> not be in the form of context diffs, just ordinary ascii.
>
> * Please run the binutils testsuites and ensure that there are no
> regressions.
ok. I will follow these points.
> One other thing - your submission included a suggested change to the top
> level config.sub file. This file is not part of the binutils project
> and you will need to submit a separate patch to have it changed. This
> patch should be sent to config-patches@gnu.org.
I have sent the change of config.sub to config-patches@gnu.org.
What is the next step to enter binutils main tree?
> Cheers
> Nick
>