This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

fix extra alignment for Xtensa literal_position directive

I've committed this patch to fix a minor problem when using the Xtensa absolute_literals directive. The literal_position directive was inadvertently inserting an alignment to a word boundary when the absolute_literals mode was enabled. Aside from an erroneous conditional, it turns out that this alignment is redundant in all cases, so the patch removes it.

2006-08-25  Sterling Augustine  <>
	    Bob Wilson  <>

	* config/tc-xtensa.c (xtensa_mark_literal_pool_location): Do not check
	the state of the absolute_literals directive.  Remove align frag at
	the start of the literal pool position.
Index: config/tc-xtensa.c
RCS file: /cvs/src/src/gas/config/tc-xtensa.c,v
retrieving revision 1.69
diff -u -p -r1.69 tc-xtensa.c
--- config/tc-xtensa.c	25 Aug 2006 00:08:55 -0000	1.69
+++ config/tc-xtensa.c	25 Aug 2006 19:56:07 -0000
@@ -4516,12 +4516,9 @@ xtensa_mark_literal_pool_location (void)
   emit_state s;
   fragS *pool_location;
-  if (use_literal_section && !directive_state[directive_absolute_literals])
+  if (use_literal_section)
-  frag_align (2, 0, 0);
-  record_alignment (now_seg, 2);
   /* We stash info in these frags so we can later move the literal's
      fixes into this frchain's fix list.  */
   pool_location = frag_now;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]