This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: 2006-05-11 change to pe-dll.c breaks Windows DLLs
On Thu, Aug 17, 2006 at 08:19:52AM +0100, Pedro Alves wrote:
>Christopher Faylor wrote:
>>On Thu, Aug 17, 2006 at 01:00:36AM -0400, Christopher Faylor wrote:
>>>The change following the "Huh?" below causes problems for x86 Windows
>>>DLLs.
>>
>>Btw, the problem that I'm seeing is that Windows DLLs produced by ld can
>>no longer be relocated -- which sort of makes sense given this change.
>>
>>[snip]
>>>Pedro can you explain why this is needed? Should it possibly be
>>>conditionalized only for your ARM target?
>>>
>
>I can't say I understand it myself. It was part of some pending patches
>I had that I found somewhere else when I started hacking binutils (as
>explained on the mail where I posted that patch), for which I don't know
>the author (I think it was Mamaich).
>That part has been making me nervous too, and I have it removed in my
>local tree for a while, in the hope I would see the reason for it.
>I don't.
>I am *very* sorry that it caused trouble.
It's really no problem. I'm afraid that I will have to demand a refund,
however. :-)
>Proposed patch attached that reverts the offending parts. Please
>review and commit.
>
>ld/Changelog
>
> 2006-08-17 Pedro Alves <pedro_alves@portugalmail.pt>
>
> * pe-dll.c (autofilter_symbolprefixlist): Remove .idata$.
> (generate_reloc): Revert to skipping sections without a
> SEC_LOAD flag, and to not skipping .idata* sections.
Reviewed and committed.
Thanks for the quick response.
cgf