This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Add DWARF debugging format support for arm-wince-pe


Daniel Jacobowitz wrote:
On Sat, Aug 05, 2006 at 01:39:26AM +0100, Pedro Alves wrote:
I don't know which is the correct value to return in
bfd_get_sign_extend_vma. I tested it with 1 and 0, but found no
difference.
What is the correct value? How does one test for it?

For a pure 32-bit architecture, it doesn't really matter. But in general 0 is correct.


Ok. Than should I 'else if' ?:


  if (strncmp (name, "coff-go32", sizeof ("coff-go32") - 1) == 0
      || strcmp (name, "pe-i386") == 0
      || strcmp (name, "pei-i386") == 0)
      return 1;
  else if (strcmp (name, "pe-arm-little") == 0
      || strcmp (name, "pei-arm-little") == 0)
    return 0;

or, should i386 return 0 too ?:

  if (strncmp (name, "coff-go32", sizeof ("coff-go32") - 1) == 0
      || strcmp (name, "pe-i386") == 0
      || strcmp (name, "pei-i386") == 0
      || strcmp (name, "pe-arm-little") == 0
      || strcmp (name, "pei-arm-little") == 0)
      return 0;


or, simply leave i386 and arm returning 1, until this hack is cleaned up?

Cheers,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]