This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] (version 2) Change MIPS linker stubs to allow for more than 2^15 symbols.
- From: David Daney <ddaney at avtrex dot com>
- To: Thiemo Seufer <ths at networkno dot de>
- Cc: binutils at sourceware dot org
- Date: Thu, 08 Jun 2006 16:11:56 -0700
- Subject: Re: [PATCH] (version 2) Change MIPS linker stubs to allow for more than 2^15 symbols.
- References: <4488A29D.5040100@avtrex.com> <20060608230248.GE25431@networkno.de>
Thiemo Seufer wrote:
David Daney wrote:
--- 8020,8061 ----
MIPS_ELF_STUB_SECTION_NAME (dynobj));
BFD_ASSERT (s != NULL);
! BFD_ASSERT ((MIPS_FUNCTION_STUB_SIZE (info) == 20)
! || (h->dynindx <= 65536));
!
! /* Values up to 2^31 - 1 are allowed. Larger values would cause
! * sign extension at runtime in the stub, resulting in a negative
! * index value.
! */
! if (h->dynindx & 0x80000000)
return FALSE;
/* Fill the stub. */
! idx = 0;
! bfd_put_32 (output_bfd, STUB_LW (output_bfd), stub + idx);
! idx += 4;
! bfd_put_32 (output_bfd, STUB_MOVE (output_bfd), stub + idx);
! idx += 4;
! if (MIPS_FUNCTION_STUB_SIZE (info) == 20)
! {
! bfd_put_32 (output_bfd, STUB_LUI ((h->dynindx >> 16 ) & 0xffff),
Formatting. Otherwise ok for trunk.
I try to keep current on GNU coding standards, but could you tell me
which aspect of the formatting is non-compliant?
David Daney.