This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch RFC] Fix PR binutils/2584

Alan Modra <amodra@bigpond.net.au> wrote:
>>    while (len--)
>>      value = value << 4 | hex_value(*src++);
> 
> You missed checking for a valid hex number here.  Otherwise the patch
> looks OK.

Oops.  I'll change that lines to

   while (len--)
     {
       if (!ISHEX (*src))
	 return FALSE;
       value = value << 4 | hex_value (*src++);
     }

and commit the patch after the test.  Thanks for reviewing.

Regards,
	kaz
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]