This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: ld/2338: objdump -d -l doesn't work correctly

From: Alan Modra <amodra at bigpond dot net dot au>
To: "H. J. Lu" <hjl at lucon dot org>, Eric Botcazou <ebotcazou at adacore dot com>, binutils at sourceware dot org
Date: Mon, 6 Mar 2006 10:11:30 +1030
Subject: Re: PATCH: ld/2338: objdump -d -l doesn't work correctly
References: <20060228072903.GN7365@bubble.grove.modra.org> <20060228171441.GA9154@lucon.org> <20060228182352.GA9662@lucon.org> <20060228185053.GA1056@nevyn.them.org> <20060228194138.GA10210@lucon.org> <20060303024209.GB6777@bubble.grove.modra.org> <20060303051635.GA1077@lucon.org> <20060303081411.GD6777@bubble.grove.modra.org> <20060303174639.GA6574@lucon.org> <20060305224536.GF6777@bubble.grove.modra.org>

On Mon, Mar 06, 2006 at 09:15:36AM +1030, Alan Modra wrote:
> I'd rather see something like the following (untested!).  If this works
> for you, then this add_line_info patch along with the rest of your patch
> is OK to commit.

Hmm, I see there isn't any real need for the outer loop in
add_line_info.  I'll make a follow-up patch after you commit this one.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Follow-Ups:
- Re: PATCH: ld/2338: objdump -d -l doesn't work correctly
  - From: H. J. Lu

References:
- Re: PATCH: ld/2338: objdump -d -l doesn't work correctly
  - From: Alan Modra
- Re: PATCH: ld/2338: objdump -d -l doesn't work correctly
  - From: H. J. Lu
- Re: PATCH: ld/2338: objdump -d -l doesn't work correctly
  - From: Alan Modra
- Re: PATCH: ld/2338: objdump -d -l doesn't work correctly
  - From: H. J. Lu
- Re: PATCH: ld/2338: objdump -d -l doesn't work correctly
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]