This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: ld/2338: objdump -d -l doesn't work correctly


On Tue, Feb 28, 2006 at 10:23:52AM -0800, H. J. Lu wrote:
> On Tue, Feb 28, 2006 at 09:14:41AM -0800, H. J. Lu wrote:
> > > HJ, "may not work correctly" doesn't say anything about why you really
> > > need a gap.  If you do need a gap, then there is a bug somewhere else.
> > > That should be fixed.  Presumably the same problem, whatever it is,
> > > could affect final linked executables with more than one text section.
> > 
> > decode_line_info in dwarf2.c calls add_line_info for both low_pc
> > and high_pc. If there is no gap, there may be 2 entries in line info
> > table with the same address. The line info looks up will fail if
> > an address matches more than 2 lines.
> > 
> 
> add_line_info should sort entries with the same address by line number.
> This patch does that.

Anything related to debug info line mappings that needs to sort by line
number is very suspect.  It sounds like you're hacking around invalid
or misinterpreted data.

Maybe you just need to handle end_sequence specially, possibly again
by sorting it before other entries.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]