This is the mail archive of the
mailing list for the binutils project.
Re: [PATCH] Re: Your gas changes caused weakref failures forcris-elf, supposedly others too
>> - && S_IS_DEFINED (symbolP)
>> + && (S_IS_DEFINED (symbolP)
>> + || symbol_equated_p (symbolP)
>> + || S_GET_VALUE (symbolP))
>Please use S_IS_COMMON here rather than S_GET_VALUE,
Actually, with the section set correctly on common symbols using
S_IS_COMMON here and in the other two places you pointed out shouldn't
be necessary anymore; S_IS_DEFINED should now take care of this. I'm
re-testing the respectively modified patch, and that probably won't be
ready before I leave the office today. Let me know if I should post the
modified patch for review again (I assume there is no need to),
otherwise I'll go ahead and commit it after testing (and send the final
patch to the list for reference).