This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/hpux] Implement file_matches_executable_p

On Fri, Nov 11, 2005 at 06:04:52PM -0800, Joel Brobecker wrote:
> Hello,
> The attached patch implements file_matches_executable_p for HP/UX.
> The intent is to have GDB print a little warning when core file and
> executable name do not match, as it already does on x86-linux.
> While at it, I saw that the file could use a bit of ansification,
> and a touch of cleanup, plus some comment addition.
>         * hpux-core.c: ANSIfy function declarations and prototypes.
>         (thread_section_p): Add comment.
>         (hpux_core_core_file_matches_executable_p): Add full implementation.
> Tested on pa-hpux using GDB. No warning before the modification, the
> warning appears after.
> OK to apply?

Silly question but... there's nothing HP/UX specific in this.  It just
uses bfd_core_file_failing_command.  Why can't this be a generic

It looks like ELF offers both failing command and failing program, and
we want to use failing program.  But for any target that doesn't do
that, your implementation is probably good.

Daniel Jacobowitz
CodeSourcery, LLC

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]