This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Your gas changes caused weakref failures for cris-elf,supposedly others too
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: aoliva at redhat dot com, JBeulich at novell dot com
- Cc: binutils at sourceware dot org
- Date: Sat, 29 Oct 2005 12:55:02 +0200
- Subject: Re: Your gas changes caused weakref failures for cris-elf,supposedly others too
> From: Alexandre Oliva <aoliva@redhat.com>
> Date: Thu, 27 Oct 2005 14:18:00 -0200
> On Oct 27, 2005, "Jan Beulich" <JBeulich@novell.com> wrote:
>
> > I'd rather go for the not re-definable option. I'll soon submit an
> > adjustment to the test case, but changing s_weakref to actually filter
> > out already defined symbols probably is better done by you, as you wrote
> > the original code.
>
> I actually copied that portion of the code from the code that handled
> .set, so I'd leave it for you to apply the same fix, if you don't mind
> :-)
While you two discuss where and how to fix this, I've entered
gas/1630 for this issue with you both CC:ed. I've also xfailed
the test for cris-*-* to avoid having to check the autotester
log for other FAILs every time someone commits something, and
mmix-*-* as well since I see the FAILs there too. I guess the
relevant pattern is *-*-* (for one, I see it for native
x86_64-unknown-linux-gnu) but maybe not, as one of you should've
seen the failures when testing.
gas/testsuite:
PR gas/1630
* gas/all/gas.exp <weakref1, weakref1g, weakref1l, weakref1u,
weakref1w>: Xfail for cris-*-* and mmix-*-*.
Index: gas/all/gas.exp
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/gas.exp,v
retrieving revision 1.33
diff -p -u -r1.33 gas.exp
--- gas/all/gas.exp 27 Oct 2005 07:40:07 -0000 1.33
+++ gas/all/gas.exp 29 Oct 2005 10:49:32 -0000
@@ -256,10 +256,15 @@ if { ![istarget "i960-*-*"] } {
case $target_triplet in {
{ z80-*-* } { }
default {
+ setup_xfail cris-*-* mmix-*-*
run_dump_test weakref1
+ setup_xfail cris-*-* mmix-*-*
run_dump_test weakref1g
+ setup_xfail cris-*-* mmix-*-*
run_dump_test weakref1l
+ setup_xfail cris-*-* mmix-*-*
run_dump_test weakref1u
+ setup_xfail cris-*-* mmix-*-*
run_dump_test weakref1w
}
}
brgds, H-P