This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: patch ping
On Wed, Sep 28, 2005 at 11:27:36AM -0400, Daniel Jacobowitz wrote:
> On Wed, Sep 28, 2005 at 07:48:44AM -0700, H. J. Lu wrote:
> > On Wed, Sep 28, 2005 at 09:23:50PM +0930, Alan Modra wrote:
> > >
> > > I started looking at this one, and got as far as the following patch:
> > > * readelf.c (debug_apply_rela_addends): Relocate the whole
> > > section.
> > >
> > > I'll leave this one for Nick to review, since I'm not sure of the
> > > ramifications of this FIXME.
> > > + /* FIXME: The relocation field size is relocation type dependent. */
> > > + unsigned int reloc_size = 4;
> >
> > It shouldn't matter unless the addend is >= 0xffffffff, which is quite
> > rare.
>
> Or negative and sign extended? e.g. mips64.
>
MIPS is handled explicitly in debug_apply_rela_addends. But I have
no idea if it is done right or not. If we really want to make
debug_apply_rela_addends 100% correctly, it should get the relocation
size from the relocation type.
H.J.