This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Look for matching closing quote in gas/app.c


Op woensdag 28 september 2005 15:22, schreef Alan Modra:
> On Wed, Sep 14, 2005 at 10:53:13PM +0200, Arnold Metselaar 
wrote:
> > While working on gas-Z80 I also noticed that
> > do_scrub_chars() in gas/app.c does not distinguish between
> > a closing quote and another quote. That is .string "this
> > looks like a terminated string to do_scrub_chars().'
> > .string "and it thinks that this one isn't."
>
> I think you missed a place where quotechar needs to be set,
> and some where it should be used.  How does the following
> look to you?
>
> 	* app.c (do_scrub_chars): Match open and close quote of
> strings. Remove redundant EOF test in case 7.
>
> [...]

You are right about the things I missed. the revised patch looks 
good to me.

Arnold


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]