This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch ping] GAS supports for MIPS32 DSP ASE



On Aug 12, 2005, at 5:19 PM, Chao-ying Fu wrote:


*************** struct mips_opcode
*** 411,417 ****
  #define INSN_ISA64R2              0x00000100

  /* Masks used for MIPS-defined ASEs.  */
! #define INSN_ASE_MASK           0x0000f000

  /* MIPS 16 ASE */
  #define INSN_MIPS16               0x00002000
--- 447,453 ----
  #define INSN_ISA64R2              0x00000100

  /* Masks used for MIPS-defined ASEs.  */
! #define INSN_ASE_MASK           0x0400f000

  /* MIPS 16 ASE */
  #define INSN_MIPS16               0x00002000
*************** struct mips_opcode
*** 419,424 ****
--- 455,462 ----
  #define INSN_MIPS3D               0x00004000
  /* MDMX ASE */
  #define INSN_MDMX                 0x00008000
+ /* DSP ASE */
+ #define INSN_DSP                0x04000000


Why?


+ {"bposge32", "p", 0x041c0000, 0xffff0000, CBD, 0, D32
},


CBD? And you didn't add the DSP_VOLA that you mentioned above.

Otherwise it looks good.

-eric


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]