This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: arm-elf-ld 2.16.1 crash at bfd/elf32-arm.c:5536

From: Nick Clifton <nickc at redhat dot com>
To: Paul Brook <paul at codesourcery dot com>
Cc: binutils at sources dot redhat dot com, Shaun Jackman <sjackman at gmail dot com>
Date: Mon, 08 Aug 2005 12:16:14 +0100
Subject: Re: arm-elf-ld 2.16.1 crash at bfd/elf32-arm.c:5536
References: <7f45d939050728162929bb9286@mail.gmail.com> <200508052302.59210.paul@codesourcery.com> <42F5D267.7010706@redhat.com> <200508071332.23874.paul@codesourcery.com>

Hi Paul,

Nearly. A couple of bugs: You were only defining bfd_elf32_close_and_cleanup for the symbian configuration,

Oops!

and unrecord_section_with_arm_elf_section_data was trying to free() memory not allocated with malloc.
Updated patch attached.
Ok?

Yes, but I decided that removing the call to free() in unrecorded... is not quite right. We would just be leaking memory that way. Well, actually we probably won't be since the memory will be freed when the bfd is released, but this assumes that the bfd is released in a timely fashion. I prefer to have explicit malloc()s and free()s so that we know when the memory is supposed to be valid.

So with that one small change I have checked our combined patch in, and I'll close the PR again.

Cheers
  Nick

References:
- Re: arm-elf-ld 2.16.1 crash at bfd/elf32-arm.c:5536
  - From: Paul Brook
- Re: arm-elf-ld 2.16.1 crash at bfd/elf32-arm.c:5536
  - From: Nick Clifton
- Re: arm-elf-ld 2.16.1 crash at bfd/elf32-arm.c:5536
  - From: Paul Brook

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]