This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: PR ld/975: [Regression]: ld -pie generates DT_TEXTREL
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 11 Jul 2005 20:52:54 +0930
- Subject: Re: PATCH: PR ld/975: [Regression]: ld -pie generates DT_TEXTREL
- References: <20050527230900.GA1191@lucon.org> <20050528001518.GA2251@lucon.org>
On Fri, May 27, 2005 at 05:15:18PM -0700, H. J. Lu wrote:
> PR 975
> * elflink.c (_bfd_elf_symbol_refs_local_p): Only undefined
> symbol with default visibility is local.
This patch causes testsuite failures. On powerpc-linux, I see
FAIL: visibility (hidden_undef) (non PIC)
FAIL: visibility (hidden_undef) (non PIC, load offset)
FAIL: visibility (hidden_undef) (PIC main, non PIC so)
FAIL: visibility (protected_undef) (non PIC)
FAIL: visibility (protected_undef) (non PIC, load offset)
FAIL: visibility (protected_undef) (PIC main, non PIC so)
You changed the meaning of _bfd_elf_symbol_refs_local_p, and I didn't
see any approval for the change. Please revert.
--
Alan Modra
IBM OzLabs - Linux Technology Centre