This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Adjust MIPS hidden symbol handling


On Tue, Apr 19, 2005 at 07:51:02PM +0100, Maciej W. Rozycki wrote:
> On Tue, 19 Apr 2005, Daniel Jacobowitz wrote:
> 
> > Nah, I was wrong.  The two flags aren't quite the same: the
> > mips-specific flag is used for accounting when we convert a global GOT
> > entry to a local one.  So only the assertion is wrong. 
> > h->forced_local implies h->root.forced_local, but not the other way
> > around.
> 
>  This sounds like the correct interpretation -- now that you've mentioned 
> that GOT reference I've recalled doing some work in that area long ago 
> when support for linker scripts (and converting symbols to local this way) 
> was added to the MIPS backend.  I can have a look at the relevant code 
> again if you discover any further problems.

Thanks, that fits.  One big difference I encountered between the two
cases is that symbols added by a linker script are never passed to the
backend hide_symbol function.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]