This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] x86: .bss/.previous interaction


i386's and x86-64's .bss did not interact correctly with ELF's .previous.

Built and tested on i686-pc-linux-gnu as well as for i686-coff and i686-aout.

Jan

gas/
2005-03-31  Jan Beulich  <jbeulich@novell.com>

	* config/tc-i386.c (s_bss): Call obj_elf_section_change_hook.

gas/testsuite/
2005-03-31  Jan Beulich  <jbeulich@novell.com>

	* gas/i386/bss.[sd]: New.
	* gas/i386/i386.exp: Run new test.

--- /home/jbeulich/src/binutils/mainline/2005-03-31/gas/config/tc-i386.c	2005-03-14 15:08:07.000000000 +0100
+++ 2005-03-31/gas/config/tc-i386.c	2005-03-31 17:19:26.899585544 +0200
@@ -5306,6 +5306,10 @@ s_bss (ignore)
 {
   int temp;
 
+#if defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF)
+  if (IS_ELF)
+    obj_elf_section_change_hook ();
+#endif
   temp = get_absolute_expression ();
   subseg_set (bss_section, (subsegT) temp);
   demand_empty_rest_of_line ();
--- /home/jbeulich/src/binutils/mainline/2005-03-31/gas/testsuite/gas/i386/bss.d	1970-01-01 01:00:00.000000000 +0100
+++ 2005-03-31/gas/testsuite/gas/i386/bss.d	2005-03-31 16:17:50.000000000 +0200
@@ -0,0 +1,7 @@
+#objdump: -s
+#name: i386 .bss
+
+.*: +file format .*
+
+Contents of section \.other:
+ 0000 0102 .*
--- /home/jbeulich/src/binutils/mainline/2005-03-31/gas/testsuite/gas/i386/bss.s	1970-01-01 01:00:00.000000000 +0100
+++ 2005-03-31/gas/testsuite/gas/i386/bss.s	2005-03-31 16:19:26.000000000 +0200
@@ -0,0 +1,7 @@
+ .data
+ .section .other, "a", @progbits
+ .byte 1
+ .bss
+ .skip 1
+ .previous
+ .byte 2
--- /home/jbeulich/src/binutils/mainline/2005-03-31/gas/testsuite/gas/i386/i386.exp	2005-03-31 16:25:51.000000000 +0200
+++ 2005-03-31/gas/testsuite/gas/i386/i386.exp	2005-03-31 17:10:14.200608560 +0200
@@ -135,3 +135,13 @@ if [expr ([istarget "i*86-*-*"] || [ista
 
     set ASFLAGS "$old_ASFLAGS"
 }
+
+if { ([istarget i*86-*-*] || [istarget x86_64-*-*]) } then {
+    if { [istarget *-*-elf*]
+	 || [istarget *-*-linux*]
+	    && ![istarget *-*-linux*aout*]
+	    && ![istarget *-*-linux*oldld*]
+    } then {
+	run_dump_test "bss"
+    }
+}


Attachment: binutils-mainline-x86-elf-bss.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]