This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Handling of unary +

From: Nick Clifton <nickc at redhat dot com>
To: Jan Beulich <JBeulich at novell dot com>
Cc: binutils at sources dot redhat dot com
Date: Tue, 15 Mar 2005 14:17:40 +0000
Subject: Re: [PATCH] Handling of unary +
References: <s2318f49.079@emea1-mh.id2.novell.com>

Hi Jan,

gas/
2005-03-11  Jan Beulich  <jbeulich@novell.com>

	* expr.c (operand): Merge handling of unary + into that for
unary
	-, !, and ~.

Approved please apply, but ...

     case '-':
+    case '+':
       {
-        /* Do not accept --e as -(-e)
+	/* Do not accept ++e or --e as +(+e) or -(-e)
 	   Disabled, since the preprocessor removes whitespace.  */
-	if (0 && c == '-' && *input_line_pointer == '-')
+	if (0 && (c == '-' || c == '+') && *input_line_pointer == c)
 	  goto target_op;

Is there really any need to preserve/modify suppressed code ? Maybe this particular fragment could just be replaced with a comment ?

Cheers
  Nick

References:
- [PATCH] Handling of unary +
  - From: Jan Beulich

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]