This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Add -Werror to build_warnings
- From: Paul Schlie <schlie at comcast dot net>
- To: Zack Weinberg <zack at codesourcery dot com>
- Cc: Alan Modra <amodra at bigpond dot net dot au>,Ben Elliston <bje at au1 dot ibm dot com>,<binutils at sources dot redhat dot com>,Nick Clifton <nickc at redhat dot com>
- Date: Fri, 18 Feb 2005 00:06:11 -0500
- Subject: Re: Add -Werror to build_warnings
> From: Zack Weinberg <zack@codesourcery.com>
> Would you please write complete sentences? Your telegraphic style is
> extremely difficult to read.
>> Paul Schlie <schlie@comcast.net> writes:
>> - Fully understand your position in general, however honestly question the
>> utility of the specific warning: of a comparison between two pointers to
>> otherwise equivalent rank data types which only in sign-ness; as it's not
>> clear that such a comparison could ever lead to unintended consequences,
>
> You are mistaken. We flushed all these warnings out of GCC about a
> year ago, and we found real bugs. Mostly, if I recall correctly, they
> were cases where the two pointers should never have been being
> compared in the first place, and this was the only diagnostic you got.
- OK, I accept that it basically forces you to at least look; at which time
you may discover something that wasn't intended somewhere. Which one could
argue is better than nothing.
Thanks,