This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: ld/emultempl/elf32.em trusts inode numbers even under Mingwin
- From: Zack Weinberg <zack at codesourcery dot com>
- To: "Dave Korn" <dave dot korn at artimi dot com>
- Cc: "'Binutils Mailing List'" <binutils at sources dot redhat dot com>
- Date: Wed, 09 Feb 2005 10:26:50 -0800
- Subject: Re: ld/emultempl/elf32.em trusts inode numbers even under Mingwin
- References: <NUTMEGrIgwbOmQwKLAf000007f2@NUTMEG.CAM.ARTIMI.COM>
"Dave Korn" <dave.korn@artimi.com> writes:
>> -----Original Message-----
>> From: Zack Weinberg
>> Sent: 08 February 2005 20:19
>
>> It was indeed NFS remote. I agree, testing inode == 0 ought to be
>> adequate. Here's a revised patch.
>
> Looks good to me, although I'm not a mingw expert. The only tiny
> nit I might pick would perhaps be to extend the comment slightly by
> explicitly mentioning that even if a bogus match on st_inode == 0
> ever did occur, it would only be a missed optimisation rather than
> actually cause any harm; that's only an implication at the moment.
Er - is it just a missed optimization? I couldn't tell from the rest
of the code. Loading the same shared library twice *sounds* like
trouble...
zw