This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] ia64 pseudo ops with missing operands
- From: James E Wilson <wilson at specifixinc dot com>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 28 Jan 2005 16:29:24 -0800
- Subject: Re: [PATCH] ia64 pseudo ops with missing operands
- References: <s1f9f06f.051@emea1-mh.id2.novell.com>
On Thu, 2005-01-27 at 23:57, Jan Beulich wrote:
> Still, here as well as in the places you complained about before, I
> can't see how else I should describe the change in the ChangeLog entry.
That's OK. I'm just being a pedant.
> Done. For the simplicity of the change, I didn't re-run the
> build/tests...
OK.
> >You have FULL17 included twice in the mask.
> Intentionally. OpX3() expands to two expressions separated by a comma,
> and the mask needs to go into both.
So it does. Please add a comment so that someone like me won't be
tempted to "fix" this code that appears to be obviously incorrect. Or
alternatively you could add another macro which makes it obvious that
both uses of FULL17 are needed. Either way is fine. Adding a comment
is simpler. A new macro would probably be a little cleaner.
OK with this change.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com