This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
ld-elf/group1 fix for MIPS
- From: Daniel Jacobowitz <drow at false dot org>
- To: binutils at sources dot redhat dot com
- Date: Fri, 28 Jan 2005 11:07:45 -0500
- Subject: ld-elf/group1 fix for MIPS
All MIPS configurations currently fail group1. The problem is that
.globl on MIPS defaults to STT_OBJECT, because of some Irix historical
quirk:
/* On Irix 5, every global symbol that is not explicitly labelled as
being a function is apparently labelled as being an object. */
flag = BSF_OBJECT;
So the test needs to accept that the symbols might have type OBJECT.
Is this patch OK?
The other question is whether this tweak should be applied only to Irix
instead of all MIPS targets.
--
Daniel Jacobowitz
2005-01-28 Daniel Jacobowitz <dan@codesourcery.com>
* ld-elf/group1.d: Accept OBJECT symbols.
Index: ld-elf/group1.d
===================================================================
RCS file: /home/drow/rsync/src/src/ld/testsuite/ld-elf/group1.d,v
retrieving revision 1.2
diff -u -p -r1.2 group1.d
--- ld-elf/group1.d 3 Dec 2004 17:06:28 -0000 1.2
+++ ld-elf/group1.d 28 Jan 2005 15:33:22 -0000
@@ -4,6 +4,6 @@
#readelf: -s
Symbol table '.symtab' contains .* entries:
#...
- .*: 0[0]*1000 0 NOTYPE WEAK DEFAULT . foo
- .*: 0[0]*0000 0 NOTYPE GLOBAL DEFAULT UND bar
+ .*: 0[0]*1000 0 (NOTYPE|OBJECT) WEAK DEFAULT . foo
+ .*: 0[0]*0000 0 (NOTYPE|OBJECT) GLOBAL DEFAULT UND bar
#...