This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] ia64 pseudo ops with missing operands
- From: James E Wilson <wilson at specifixinc dot com>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 27 Jan 2005 18:20:05 -0800
- Subject: Re: [PATCH] ia64 pseudo ops with missing operands
- References: <s1f4d54d.090@emea1-mh.id2.novell.com>
On Mon, 2005-01-24 at 03:00, Jan Beulich wrote:
> * config/tc-ia64.c (parse_operands): Also handle alloc without
> first
> input being ar.pfs.
As before, comments should go in the source code instead of in the
ChangeLog entry.
> + i = CURR_SLOT.opnd[1].X_op == O_register
> + && CURR_SLOT.opnd[1].X_add_number == REG_AR + AR_PFS ? 2 :
> 1;
The usual way to write this is with parentheses, if you do that, then
emacs will automatically get the indentation right. E.g.
i = (CURR_SLOT.opnd[1].X_op == O_register
&& CURR_SLOT.opnd[1].X_add_number == REG_AR + AR_PFS) ? 2 :
1);
and ignore the stupid auto-wrapping mailer.
> + {"mov", I, FULL17 | OpX3 (0, 3) | FULL17, {PR, R2}, PSEUDO, 0,
> NULL},
You have FULL17 included twice in the mask.
Otherwise it looks OK.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com