This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] gas dwarf2 debug emission
On Tue, Jan 25, 2005 at 09:42:39AM +0000, Nathan Sidwell wrote:
> * dwarf2dbg.c (dwarf2_finish): Correct logic for determining when
> to emit .debug_line and other debug sections.
> * as.h (seg_not_empty_p): Declare.
> * subsegs.c (seg_not_empty_p): New predicate.
Hmm.
> Index: gas/as.h
[snip]
> - void subseg_change (segT, int);
[snip]
> ! void seg_change (segT, int);
Please don't commit this one. Looks like some other patch of yours
crept in unannounced here.
> + emit_other_sections = info_seg == NULL || seg_not_empty_p (info_seg) == 0;
Style issue here. seg_not_empty_p is obviously a predicate. It's
preferable to use '!' rather than comparing against zero in this case
(but leave info_seg == NULL test as is).
> + int
> + seg_not_empty_p (segT sec)
And in a similar vein, the return type is better as bfd_boolean.
OK with those changes.
--
Alan Modra
IBM OzLabs - Linux Technology Centre