This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Symbols in discarded sections.

From: Alan Modra <amodra at bigpond dot net dot au>
To: Paul Brook <paul at codesourcery dot com>
Cc: binutils at sources dot redhat dot com
Date: Thu, 2 Dec 2004 09:08:52 +1030
Subject: Re: [patch] Symbols in discarded sections.
References: <200412012032.07865.paul@codesourcery.com> <200412012104.01050.paul@codesourcery.com>

On Wed, Dec 01, 2004 at 09:04:01PM +0000, Paul Brook wrote:
> > bfd/
> >  * elflink.c (elf_link_add_object_symbols): Make symbols from discarded
> >  sections undefined.
> > ld/testsuite/
> >  * ld-elf/group1.d: New test.
> >  * ld-elf/group.ld, ld-elf/group1a.s, ld-elf/group1b.s: New test.

I like it.  One nit:

> +	else if (sec->kept_section
> +		 && bfd_is_abs_section (sec->output_section))

The output section test is redundant.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

References:
- [patch] Symbols in discarded sections.
  - From: Paul Brook
- Re: [patch] Symbols in discarded sections.
  - From: Paul Brook

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]