This is the mail archive of the
mailing list for the binutils project.
Re: RFA: Support for Thumb in dynamic objects
On Wed, 2004-11-17 at 16:48, Daniel Jacobowitz wrote:
> On Wed, Nov 17, 2004 at 01:48:06PM +0000, Richard Earnshaw wrote:
> > > OK? Comments?
> > This is OK once you've addressed the point Paul raised. You might also
> > have to look at the tests when run in big-endian mode too.
> I missed some arm-elf vs arm-linux issues, and some big vs little
> endian issues; no one's run the testsuite in big-endian in a while.
> I'm reposting for review. There are two changes in the patch that I
> would like someone else to look at:
> - I fixed a big-endian Thumb disassembly bug. It would read past
> the end of the section.
Can you use a macro rather than ~0x3?
> - I updated the patterns in the gas unwind tables test. There's some
> funny byte and nibble swapping going on, so I'd appreciate it if
> someone (Paul?) could tell me whether the big-endian pattern is correct;
> it matches gas's output now.
This is clearly OK, the values in the big-endian side of the table
should clearly be the byte-swapped versions of the little-endian side.
> Passes the testsuite on arm-elf, armeb-elf, and arm-linux.
Other than that, OK.