This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] make elf_find_function capable of reporting a filename


Realizing that elf_find_function never reported a file name, I found
that
it had an ill (wrong for file symbols, redundant for others) check for
matching the target section.

Build and tested on i686-pc-linux-gnu.

bfd/
2004-10-06 Jan Beulich <jbeulich@novell.com>

	* elf.c (elf_find_function): Don't generally check for matching
	section, just for non-file symbols. Remove redunant comparison
	for the latter.

---
/home/jbeulich/src/binutils/mainline/2004-10-06.09.37/bfd/elf.c	2004-10-06
09:35:46.000000000 +0200
+++ 2004-10-06.09.37/bfd/elf.c	2004-10-06 10:12:57.415232480 +0200
@@ -6304,9 +6304,6 @@ elf_find_function (bfd *abfd ATTRIBUTE_U
 
       q = (elf_symbol_type *) *p;
 
-      if (bfd_get_section (&q->symbol) != section)
-	continue;
-
       switch (ELF_ST_TYPE (q->internal_elf_sym.st_info))
 	{
 	default:
@@ -6316,7 +6313,7 @@ elf_find_function (bfd *abfd ATTRIBUTE_U
 	  break;
 	case STT_NOTYPE:
 	case STT_FUNC:
-	  if (q->symbol.section == section
+	  if (bfd_get_section (&q->symbol) == section
 	      && q->symbol.value >= low_func
 	      && q->symbol.value <= offset)
 	    {

Attachment: binutils-mainline-elf-find-function.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]