This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Thu, Jul 01, 2004 at 04:46:30PM +0100, Nick Clifton wrote: > Hi H. J. > > >>Also, would it be possible to include a test somewhere that checks the > >>behaviour of this patch ? > > >Here is a testcase: > > > >[hjl@gnu 1]$ make > >gcc -c foo.s > >gcc -c bar.s > >ld -r -o new.o foo.o bar.o > >bar: discarded in section `.text[.foo]' from bar.o > >make: [new.o] Error 1 (ignored) > > > >/usr/bin/ld -r -o old.o foo.o bar.o > >bar: discarded in section `.text' from bar.o > >make: [old.o] Error 1 (ignored) > > > >There may be many `.text' sections in bar.o. `.text[.foo]' is more > >useful. > > Thanks - that makes your patch clearer. Please consider the patch approved. > Nick, I have an updated patch http://sources.redhat.com/ml/binutils/2004-06/msg00606.html The difference is bfd_get_section_ident will malloc a buffer for the section identifier. The change is limited to bfd. I also updated ld to use bfd_get_section_ident. Alan suggested use elf_group_name. Here is an updated patch. H.J.
Attachment:
binutils-sec-ident-4.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |