Re: [PATCH] x86-64 opcode corrections

["Jan Beulich" <JBeulich at novell dot com>]

Certainly, though I've been told that same mailer also doesn't handle text attachments well (they come through marked as binary of some sort), so I'm sorry for that in advance (the contents, of course, is OK). Jan

>>> Andreas Jaeger <aj@suse.de> 04.06.04 07:55:36 >>>
"Jan Beulich" <JBeulich@novell.com> writes:

> A lot of illegal instructions were accepted by the assembler, and in a
> few cases useless rex prefixes would have been generated.
>
> 2004-06-03 Jan Beulich <jbeulich@novell.com>
>
> 	* include/opcode/i386.h: Adjust instructions descriptions to
> better
> 	match the specification.
> 	* gas/testsuite/gas/cfi/cfi-x86_64.d: Adjust expectation for
> leave to
> 	not have a rex prefix.
> 	* gas/testsuite/gas/i386/x86-64-inval.[ls]: Add a bunch of
> instructions
> 	illegal in 64-bit mode.

Those instructions are indeed illegal, I've checked them all.

Your mailer wraps around the lines - that makes it difficult to read
the patch.

Can you resend this patch - and your other one - in a way that it's
properly generated, perhaps as attachment?

Thanks,
Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj 
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: binutils-mainline-x86_64-opcodes.patch
Description: Binary data