This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Minor coding nitpick in binutils/bfd/elf32-v850.c


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Excuse me, can I ask a small question?

What's this?

binutils/bfd/elf32-v850.c: v850_elf_final_link_relocate():

    case R_V850_SDA_16_16_SPLIT_OFFSET:
	...
        value -= sym_sec->output_section->vma;
        value -= (gp - sym_sec->output_section->vma);


That's just equivalent to (*)
        value -= gp;

Other relocs nearby also do that v -= x; v -= (y - x); dance.

I must be missing something...

(*) <selects appropriate signature>

- -- 
http://voyager.abite.co.za/~berndj/ (f1084a555d2098411cff4cefd41d2e2a1c85d18c)
I've generally found that the fastest way to get the right answer on the net
is to confidently assert the answer you believe to be right; those who know
will immediately correct you, while if you just ask, often no answers arrive.
All it requires is a willingness to look bad on occasion.
                                               - Joe Buck on gcc@gcc.gnu.org
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQFAn6HJ/FmLrNfLpjMRAtEHAKCIBdYjbIkItFXmQvjjVW6WoOFLQwCeOUsg
4aXVPvmfRGURp2J0PZw0uyE=
=3swa
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]