Re: [PATCH] Support DWARF 2/3 on i?86 PE

[Brian Ford <ford at vss dot fsi dot com>]

On Fri, 16 Apr 2004, Alan Modra wrote:

> On Thu, Apr 15, 2004 at 10:35:54PM -0500, Brian Ford wrote:
> > http://sources.redhat.com/ml/binutils/2004-04/msg00169.html
>
> This patch is OK for mainline, provided you fix the comment formatting.

Thanks.

I assume you mean remove the leading * from the second line and end with
two spaces before the */?  Sorry,  I know better.  But, I wanted to
clarify and make sure I wasn't missing anything else.

> Hmm, actually the comment is wrong.  You want:
>
> 	/* The first non-zero section filepos is the header size.
> 	   Sections without contents will have a filepos of 0.  */

I agree that says *approximately* the same thing, so I have changed it
accordingly.  But, I still don't understand why you think the original
comment was wrong?

"Orphaned and alloc only sections may have a filepos of 0."

Orphaned sections may have contents.  They just don't end up in the output
file.  Also, alloc only implies no contents.

Sorry, I just don't get it.

> > http://sources.redhat.com/ml/binutils/2004-03/msg00542.html
>
> This is also OK.

Ok, but as I said in a previous email, I don't have a sources.redhat.com
account, or binutils write access.  Did you want to check these two in, or
do you want to "sponsor" me for "Write After Approval" access?  I'll
submit the appropriate form if so.

Thanks again.

-- 
Brian Ford
Senior Realtime Software Engineer
VITAL - Visual Simulation Systems
FlightSafety International
Phone: 314-551-8460
Fax:   314-551-8444