This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix a ppc64 make check failure


On Fri, Mar 26, 2004 at 04:38:14PM +0100, Jakub Jelinek wrote:
> Hi!
> 
> Current CVS fails the
> Running /usr/src/build/381510-ppc64/BUILD/binutils-2.15.90.0.1.1/binutils/testsuite/binutils-all/objcopy.exp ...
> Version /usr/src/build/381510-ppc64/BUILD/binutils-2.15.90.0.1.1/build-ppc64-redhat-linux/binutils/objcopy 20040326
> FAIL: run stripped executable with saving a symbol

Huh?

home/alan/build/ppc/bin64/binutils/nm-new  tmpdir/striprog
Executing on host: /home/alan/build/ppc/bin64/binutils/nm-new  tmpdir/striprog   (timeout = 300)
0000000010000564 T main
0000000010000564 T main

PASS: run stripped executable with saving a symbol

Hmm, that is odd.  Apparently these tests don't respect the environment
CC variable, thus my test runs in binutils/ have always been compiling
32 bit powerpc code.  :-(

> test on ppc64.  nm outputs address D main while the test expected address T main.
> This uses the same regex as is used in another place in objcopy.exp.
> Ok to commit?
> 
> 2004-03-26  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* binutils-all/objcopy.exp: Accept main as a data symbol as well.

OK.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]