This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [wip:binutils] Large corefile support


jtc@acorntoolworks.com (J.T. Conklin) writes:


If file_ptr is changed to be defined in terms of long/off_t/off64_t
(depending on what's available on the host), it seems worthwhile to
create a bfd_fseek() that wraps fseek/fseeko/fseeko64 (likewise for
bfd_ftell() and ftell/ftello/ftello64) so that conditionals for each
type are isolated in a single place.


Yes, I agree, and we already have bfd_seek and bfd_tell.  Nothing else
should call fseek or ftell on the FILE underlying a BFD.

I'm guessing as internal-only interfaces? Nothing other than BFD, should known that the underlying implementation uses FILE.


The other option would be to publish these vis:
bfd_fseek (FILE *, file_ptr, int)
but that would mean requiring <stdio.h> (unless a "struct bfd_file *" instead of "FILE *" was used :-).


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]