This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
ppc64 @dtprel relocs in debug sections
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sources dot redhat dot com
- Cc: Jakub Jelinek <jakub at redhat dot com>
- Date: Tue, 13 Jan 2004 10:55:20 +1030
- Subject: ppc64 @dtprel relocs in debug sections
- References: <20040112152855.GZ6413@sunsite.ms.mff.cuni.cz>
This allows dtprel relocs in debug sections.
* elf64-ppc.c (ppc64_elf_check_relocs): Ignore !SEC_ALLOC relocs.
(ppc64_elf_gc_sweep_hook): Likewise.
(ppc64_elf_size_dynamic_sections): Test for .plt directly.
Index: bfd/elf64-ppc.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-ppc.c,v
retrieving revision 1.142
diff -u -p -r1.142 elf64-ppc.c
--- bfd/elf64-ppc.c 8 Dec 2003 13:05:11 -0000 1.142
+++ bfd/elf64-ppc.c 13 Jan 2004 00:18:43 -0000
@@ -3590,6 +3590,15 @@ ppc64_elf_check_relocs (bfd *abfd, struc
if (info->relocatable)
return TRUE;
+ /* Don't do anything special with non-loaded, non-alloced sections.
+ In particular, any relocs in such sections should not affect GOT
+ and PLT reference counting (ie. we don't allow them to create GOT
+ or PLT entries), there's no possibility or desire to optimize TLS
+ relocs, and there's not much point in propagating relocs to shared
+ libs that the dynamic linker won't relocate. */
+ if ((sec->flags & SEC_ALLOC) == 0)
+ return TRUE;
+
htab = ppc_hash_table (info);
symtab_hdr = &elf_tdata (abfd)->symtab_hdr;
@@ -3947,10 +3956,6 @@ ppc64_elf_check_relocs (bfd *abfd, struc
if (NO_OPD_RELOCS && opd_sym_map != NULL)
break;
- /* Don't propagate relocs that the dynamic linker won't relocate. */
- if ((sec->flags & SEC_ALLOC) == 0)
- break;
-
/* If we are creating a shared library, and this is a reloc
against a global symbol, or a non PC relative reloc
against a local symbol, then we need to copy the reloc
@@ -4166,6 +4171,9 @@ ppc64_elf_gc_sweep_hook (bfd *abfd, stru
struct got_entry **local_got_ents;
const Elf_Internal_Rela *rel, *relend;
+ if ((sec->flags & SEC_ALLOC) == 0)
+ return TRUE;
+
elf_section_data (sec)->local_dynrel = NULL;
htab = ppc_hash_table (info);
@@ -6001,7 +6009,7 @@ ppc64_elf_size_dynamic_sections (bfd *ou
}
/* .plt is in the bss section. We don't initialise it. */
- if ((s->flags & SEC_LOAD) == 0)
+ if (s == htab->plt)
continue;
/* Allocate memory for the section contents. We use bfd_zalloc
--
Alan Modra
IBM OzLabs - Linux Technology Centre