This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix demangler in symbol versioning


On Thu, Dec 04, 2003 at 12:50:24PM -0800, H. J. Lu wrote:
> This patch fixes the gcc bootstrap for me on Linux.

Is DMGL_VERBOSE really appropriate?  I don't think so, since the old
demangler never implied it by default and the new demangler doesn't
change output based on it.

> 
> 
> H.J.
> ----
> 2003-12-04  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* ldlang.c (lang_vers_match): Updated calls to cplus_demangle.
> 
> --- ld/ldlang.c.dem	2003-12-04 11:36:55.000000000 -0800
> +++ ld/ldlang.c	2003-12-04 12:40:35.000000000 -0800
> @@ -4996,13 +4996,15 @@ lang_vers_match (struct bfd_elf_version_
>  
>    if (head->mask & BFD_ELF_VERSION_CXX_TYPE)
>      {
> -      cxx_sym = cplus_demangle (sym, /* DMGL_NO_TPARAMS */ 0);
> +      cxx_sym = cplus_demangle (sym, (DMGL_PARAMS
> +				      | DMGL_ANSI
> +				      | DMGL_VERBOSE));
>        if (!cxx_sym)
>  	cxx_sym = sym;
>      }
>    if (head->mask & BFD_ELF_VERSION_JAVA_TYPE)
>      {
> -      java_sym = cplus_demangle (sym, DMGL_JAVA);
> +      java_sym = java_demangle_v3 (sym);
>        if (!java_sym)
>  	java_sym = sym;
>      }
> 

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]