This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: An unused function `print_colon_thingie' inopcodes/h8300-dis.c.
- From: Kazu Hirata <kazu at cs dot umass dot edu>
- To: msnyder at redhat dot com
- Cc: binutils at sources dot redhat dot com, bernds at redhat dot com, aoliva at redhat dot com
- Date: Wed, 19 Nov 2003 14:45:35 -0500 (EST)
- Subject: Re: An unused function `print_colon_thingie' inopcodes/h8300-dis.c.
- References: <20031119.141444.71107399.kazu@cs.umass.edu><3FBBC642.3040606@redhat.com>
Hi Michael,
> > 2003-06-03 Michael Snyder <msnyder@redhat.com>
> > and Bernd Schmidt <bernds@redhat.com>
> > and Alexandre Oliva <aoliva@redhat.com>
> >
> > * disassemble.c (disassembler): Add support for h8300sx.
> > * h8300-dis.c: Ditto.
> >
> > This patch adds an unused function `print_colon_thingie' to
> > opcodes/h8300-dis.c. Is there a plan to use it? I see a lot of
> > places that print ':' themselves, so I am guessing that this function
> > was used during development but not any more.
>
> You're right -- it was used by a pretty-printer function
> that I used during development. Please feel free to remove it.
OK. I committed the attached patch.
Kazu Hirata
2003-11-19 Kazu Hirata <kazu@cs.umass.edu>
* h8300-dis.c (print_colon_thingie): Remove.
Index: h8300-dis.c
===================================================================
RCS file: /cvs/src/src/opcodes/h8300-dis.c,v
retrieving revision 1.14
diff -u -r1.14 h8300-dis.c
--- h8300-dis.c 10 Jun 2003 07:27:55 -0000 1.14
+++ h8300-dis.c 19 Nov 2003 19:39:30 -0000
@@ -45,25 +45,6 @@
int *, int *,
const struct h8_opcode *));
-static void print_colon_thingie PARAMS ((op_type *));
-
-static void
-print_colon_thingie (op_type *nib)
-{
- switch (*nib & SIZE) {
- case L_2: fprintf (stdout, "2"); break;
- case L_3:
- case L_3NZ: fprintf (stdout, "3"); break;
- case L_4: fprintf (stdout, "4"); break;
- case L_5: fprintf (stdout, "5"); break;
- case L_8: fprintf (stdout, "8"); break;
- case L_16:
- case L_16U: fprintf (stdout, "16"); break;
- case L_24: fprintf (stdout, "24"); break;
- case L_32: fprintf (stdout, "32"); break;
- }
-}
-
/* Run through the opcodes and sort them into order to make them easy
to disassemble. */