This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: powerpc64-linux hack
- From: Ulrich Drepper <drepper at redhat dot com>
- To: Alan Modra <amodra at bigpond dot net dot au>
- Cc: binutils at sources dot redhat dot com, mostrows at watson dot ibm dot com
- Date: Mon, 11 Aug 2003 11:11:13 -0700
- Subject: Re: powerpc64-linux hack
- Organization: Red Hat, Inc.
- References: <20030811112952.GZ27145@bubble.sa.bigpond.net.au>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Alan Modra wrote:
> We won't ever be returning to anything in crt1.o, so a toc adjustment is
> fine.
>
> * elf64-ppc.c (ppc64_elf_relocate_section): Add special case for crt1.o
> branch to __libc_start_main.
That's a stupid change. There is no guarantee that future glibc
versions won't have different libc entry point names. I would never
accept hardcoding a name like this. If you need new functionality
design and implement it and use it for the __libc_start_main call. But
don't add a hack like this.
- --
- --------------. ,-. 444 Castro Street
Ulrich Drepper \ ,-----------------' \ Mountain View, CA 94041 USA
Red Hat `--' drepper at redhat.com `---------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE/N9xB2ijCOnn/RHQRAgPUAKCkIGD86/Tw8/lL49N0e8twRj8lTACfeN6w
M3CcW8Cp6Xfy4Y6OVkq/NMg=
=Y5lH
-----END PGP SIGNATURE-----