This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [Patch] pe-i386: Fix --subsystem windows option
- From: Christopher Faylor <cgf at redhat dot com>
- To: Danny Smith <danny_r_smith_2001 at yahoo dot co dot nz>
- Cc: binutils <binutils at sources dot redhat dot com>
- Date: Wed, 6 Aug 2003 21:18:16 -0400
- Subject: Re: [Patch] pe-i386: Fix --subsystem windows option
- References: <20030807003811.83459.qmail@web21414.mail.yahoo.com>
On Thu, Aug 07, 2003 at 10:38:11AM +1000, Danny Smith wrote:
>2003-08-07 Danny Smith <dannysmith@users.sourceforge.net>
>
> * emultempl/pe.em (gld_${EMULATION_NAME}_before_parse):
> Change second (cmdline) arg to lang_add_entry to FALSE.
> (set_pe_subsystem): Change second arg to lang_add_entry to TRUE.
Looks right. It seems like this has been broken for a long time.
Hard to believe.
Ok to apply.
cgf
>Index: emultempl/pe.em
>===================================================================
>RCS file: /cvs/src/src/ld/emultempl/pe.em,v
>retrieving revision 1.80
>diff -c -3 -p -r1.80 pe.em
>*** emultempl/pe.em 27 Jun 2003 00:38:25 -0000 1.80
>--- emultempl/pe.em 6 Aug 2003 23:53:08 -0000
>*************** gld_${EMULATION_NAME}_before_parse (void
>*** 141,149 ****
>
> #if (PE_DEF_SUBSYSTEM == 9) || (PE_DEF_SUBSYSTEM == 2)
> #if defined TARGET_IS_mipspe || defined TARGET_IS_armpe
>! lang_add_entry ("WinMainCRTStartup", 1);
> #else
>! lang_add_entry ("_WinMainCRTStartup", 1);
> #endif
> #endif
> #endif
>--- 141,149 ----
>
> #if (PE_DEF_SUBSYSTEM == 9) || (PE_DEF_SUBSYSTEM == 2)
> #if defined TARGET_IS_mipspe || defined TARGET_IS_armpe
>! lang_add_entry ("WinMainCRTStartup", FALSE);
> #else
>! lang_add_entry ("_WinMainCRTStartup", FALSE);
> #endif
> #endif
> #endif
>*************** set_pe_subsystem (void)
>*** 439,445 ****
> entry = alc_entry;
> }
>
>! lang_add_entry (entry, 0);
>
> return;
> }
>--- 439,445 ----
> entry = alc_entry;
> }
>
>! lang_add_entry (entry, TRUE);
>
> return;
> }
>
>http://personals.yahoo.com.au - Yahoo! Personals
>- New people, new possibilities! Try Yahoo! Personals, FREE for a limited period!