This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Doco and testsuite for last CFI update.


On Thu, Jun 05, 2003 at 12:01:00PM +0200, Michal Ludvig wrote:
> 	* as.texinfo: Document new directives: .cfi_restore, 
> 	.cfi_undefined, .cfi_same_value, .cfi_return_column, 
> 	.cfi_remember_state, .cfi_restore_state, .cfi_nop.
> 	Remove .cfi_verbose.

OK, except

> +@section @code{.cfi_remember_state}, 
> +@cindex @code{cfi_remember_state} directive
> +First save all current rules for all registers by @code{.cfi_remember_state}, 
> +then totally screw them up by subsequent @code{.cfi_*} directives and when 
> +everything is hopelessly bad, use @code{.cfi_restore_state} to restore 
> +the previous saved state.

This needs rewriting.  You don't say much more than could be inferred
from the name of the directive, and the idiom "totally screw them up" is
not acceptable for user documentation IMO.  Useful information would be
whether cfi_remember_state can be nested or not.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]