This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] use mkstemp instead of mktemp.
- From: Muthukumar Ratty <muthu at iqmail dot net>
- To: Simon Burge <simonb at wasabisystems dot com>
- Cc: Muthukumar Ratty <muthu at iqmail dot net>, <binutils at sources dot redhat dot com>, Ian Lance Taylor <ian at airs dot com>, <amodra at bigpond dot net dot au>, <hp at bitrange dot com>
- Date: Tue, 1 Jul 2003 23:39:19 -0700 (PDT)
- Subject: Re: [patch] use mkstemp instead of mktemp.
> > >
> > > You can't just mechanically replace mktemp() with mkstemp(). They
> > > have different return values.
> > >mkstemp() returns the newly opened
> > > file.
> >
> > and also modifies the template properly so I think it should be ok.
>
> Note that blindly ignoring the return value of mkstemp() and then using
> the modified template to open the file will create exactly the same race
mkstemp actually creates the file. so when we open, it should be
unique.... am i missing something?
> condition that mkstemp() was designed to fix! You'll remove the link
> time warning, but not fixed the problem the warning was warning about.
>
> Simon.
> --
> Simon Burge <simonb@wasabisystems.com>
> NetBSD Development, Support and Service: http://www.wasabisystems.com/
>