This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] MIPS gas: Cleanup address insn conditionals
- From: Eric Christopher <echristo at redhat dot com>
- To: Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>
- Cc: binutils at sources dot redhat dot com
- Date: 15 Jun 2003 23:41:43 -0700
- Subject: Re: [PATCH] MIPS gas: Cleanup address insn conditionals
- Organization:
- References: <20030615202246.GC14156@rembrandt.csv.ica.uni-stuttgart.de>
>
> +#define ADDRESS_ADD_INSN \
> + (HAVE_32BIT_ADDRESSES ? HAVE_NEWABI ? "add" : "addu" : "daddu")
> +
> +#define ADDRESS_ADDI_INSN \
> + (HAVE_32BIT_ADDRESSES ? HAVE_NEWABI ? "addi" : "addiu" : "daddiu")
> +
Hey, can you add some parens here and maybe some comments explaining the
abis? :)
-eric
--
Eric Christopher <echristo@redhat.com>