Re: MIPS patch to correct the size of %neg() fixups

[Richard Sandiford <rsandifo at redhat dot com>]

Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de> writes:
> Another thing: At least the FIXME about RSS_* values should be retained,

Well, the fixme says:

		  /* FIXME: This symbol can be one of
		     RSS_UNDEF, RSS_GP, RSS_GP0, RSS_LOC.  */

but why is that relevant in this context (append_insn)?

macro_build() only adds one fixup at a time.  If a macro like
.cpsetup needs to create a compound relocation, it adds the other
fixups separately using fix_new().

So I think the code we're talking about is only needed for processing
explicit relocation operators (%hi, etc).  And as far as I'm aware,
the syntax doesn't allow r_ssym to be anything other than RSS_UNDEF.

I didn't really see what kind of change the FIXME was anticipating.

> so I prefer a patch like the one below.

Butbutbut... why you do want to keep the reloc_type[2] code cut-&-paste
from the reloc_type[1] code? ;) I thought using a loop was an
improvement. ;)

ARichard