This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Code cleanup in bfd/reloc.c
- From: Nick Clifton <nickc at redhat dot com>
- To: Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 16 May 2003 10:41:08 +0100
- Subject: Re: [PATCH] Code cleanup in bfd/reloc.c
- References: <20030514050641.GB8833@rembrandt.csv.ica.uni-stuttgart.de>
Hi Thiemo,
> this does a bit of code cleanup.
I am not sure of the point of this code cleanup.
It seems to me that the code is basically OK as it stands at the
moment. I appreciate that the patch reduces the number of lines and
variables when handling the 'special_function' but I do not like
eliminating the intialisation of 'flag' at the start of the function
and then being forced to add an else clause to the if statement at
line 1199, and an explicit return at 1907.
Cheers
Nick