This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] CFI directives for GAS
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Cc: Michal Ludvig <mludvig at suse dot cz>, binutils at sources dot redhat dot com
- Date: Thu, 15 May 2003 18:36:37 -0700
- Subject: Re: [PATCH] CFI directives for GAS
- References: <Pine.BSF.4.44.0305152114140.32077-100000@dair.pair.com>
Hans-Peter Nilsson <hp@bitrange.com> writes:
> On Thu, 15 May 2003, Michal Ludvig wrote:
>> For now the architectures that have these new directives enabled are
>> i386 and amd64.
>>
>> Commented example on the usage can be found here:
>> http://www.logix.cz/~mic/devel/gas-cfi/example.s.html
>>
>> How do you like this idea? Any comments? Can I apply the patch?
>
> You asked for comments, so here goes my usual knee-jerk
> reaction: Cool, but how do we know this works and doesn't
> trivially break with anyone's next set of patches? Where's the
> test-suite? Even one i386 or amd64-specific case from your
> example code would be terrific. Consider that test-cases for
> new features are mandatory in GCC, and for IMHO a good reason.
Also, you didn't add any documentation. GAS already has too many
undocumented directives.
zw