Re: PATCH: Add .alias and .secalias (take 2)

["H. J. Lu" <hjl at lucon dot org>]

On Tue, May 06, 2003 at 06:39:26PM -0400, Jim Wilson wrote:
> H. J. Lu wrote:
> > On Fri, May 02, 2003 at 05:04:09PM -0700, H. J. Lu wrote:
> >>This patch adds .alias and .secalias to ia64.
> 
> I only have some minor issues with this.
> 
> You didn't add comments before each function you added/rewrote.  I 
> understand that the file is already broken this way, but we shouldn't 
> make it worse.

I added some comments.

> 
> It isn't clear why you call demand_copy_C_string for the "alias" string. 
>   If the string must be copied, then why isn't the "name" string copied 
> also?  If you are doing this only to check for \0 in the middle of the 
> string, then that should be in a comment because that is not obvious. 
> Or does this have something to do with parsing the quotes?  I can't tell 
> why the function call is there.
> 

You are right on both. I should copy "name". demand_copy_C_string is
called to parse the string. Here is an updated patch.


H.J.

Attachment: gas-ia64-alias.patch
Description: Text document