This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: check mips abi x linker emulation compatibility


Eric Christopher <echristo@redhat.com> writes:
> > I've no strong objection to adding another flag, but I think we should
> > still keep the existing tests to make sure that configurations like
> > mips-elf and mips64-elf are ABI-neutral by default.  That's always
> > been their traditional behaviour.
> 
> It looks like for the tests if we're running on a hosted target that we
> need to explicitly add the abi, otherwise we get the default. Alex could
> probably come up with a variable to add options to the tests...

Alex's patch added "-32" to command-line options that were supposed to
generate ABI-neutral objects, not o32 objects.  Adding -32 changes the
nature of the test.  I think if we added a variable, the same line would
be testing different things for different configs, which might be confusing.

The point is that, until now, all configurations were ABI-neutral
by default.  The test was written on that assumption and (to some
extent) to make sure that they remained that way.  Now that we've
given some configurations a default ABI, I suggest we just disable
the problem tests for those configurations.

Anyway, I didn't want to make such a fuss, so I'll say no more;)

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]