This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: gdb.mi/mi-cli.exp failures
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: David Carlton <carlton at math dot stanford dot edu>, gdb <gdb at sources dot redhat dot com>, <binutils at sources dot redhat dot com>
- Date: Mon, 31 Mar 2003 20:09:39 -0500 (EST)
- Subject: Re: gdb.mi/mi-cli.exp failures
On Mon, 31 Mar 2003, Andrew Cagney wrote:
> And this:
>
> > - return concat (filename);
> > + return filename;
>
> (remembering that the patch is backwards) doesn't look so good. It
> should be:
>
> concat (filename, NULL);
>
> perhaps
>
> xstrdup (filename)
>
> would be easier to read :-)
\begin{chant} There must be no xstrdup calls in bfd. BFD must
not abort; it's a library and the caller must handle allocation
failures. There may be xstrdup calls in bfd already, but please
don't add new ones. \end{chant}
brgds, H-P